-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EFR32] Upgrade LCD #22016
Merged
jepenven-silabs
merged 2 commits into
project-chip:master
from
jepenven-silabs:efr32_lcd_upgrade
Aug 19, 2022
Merged
[EFR32] Upgrade LCD #22016
jepenven-silabs
merged 2 commits into
project-chip:master
from
jepenven-silabs:efr32_lcd_upgrade
Aug 19, 2022
+877
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepenven-silabs
force-pushed
the
efr32_lcd_upgrade
branch
from
August 18, 2022 19:43
755df73
to
74a7739
Compare
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda and
msandstedt
August 18, 2022 19:44
pullapprove
bot
requested review from
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
August 18, 2022 19:44
PR #22016: Size comparison from d502f30 to 74a7739 Increases (4 builds for cc13x2_26x2, esp32, psoc6)
Decreases (3 builds for cc13x2_26x2, psoc6, telink)
Full report (38 builds for bl602, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
jmartinez-silabs
approved these changes
Aug 18, 2022
PR #22016: Size comparison from d502f30 to bc29b3c Increases above 0.2%:
Increases (19 builds for cc13x2_26x2, efr32, esp32, linux, nrfconnect, psoc6)
Decreases (5 builds for cc13x2_26x2, efr32, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
tcarmelveilleux
approved these changes
Aug 19, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* Upgrade LCD EFR32 * fix CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
LCD is under used.
Change overview
Add visual feedback for some examples.
Testing
Tested on manufacturer platform.